Skip to content

Conversation

TasoOneAsia
Copy link
Member

Proposed changes

Tweaks product selector schema to include an "extUrl" property. This property is then used in handling to assign target="_blank" when rendered.

Example:

- productGroup: Test External Links
  products:
      - title: "NGINX.org"
        url: https://nginx.org/index.html
        extUrl: true

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@TasoOneAsia TasoOneAsia self-assigned this Aug 28, 2025
@TasoOneAsia TasoOneAsia requested a review from a team as a code owner August 28, 2025 16:30
@TasoOneAsia TasoOneAsia added the enhancement New feature or request label Aug 28, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/367/

@TasoOneAsia TasoOneAsia force-pushed the tweak/product-selector/new-tabs-ext-links branch from bd395b4 to a83014e Compare August 28, 2025 16:33
Copy link
Collaborator

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM locally!

@TasoOneAsia TasoOneAsia merged commit 77abd68 into mainframe Aug 28, 2025
4 checks passed
@TasoOneAsia TasoOneAsia deleted the tweak/product-selector/new-tabs-ext-links branch August 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants